[MPlayer-dev-eng] Update libdvdcss to r255
Roger Pack
rogerdpack2 at gmail.com
Thu Nov 15 21:46:19 CET 2012
>> @@ -1188,6 +1188,7 @@
>> memset( BigTable, 0 , 16777216 * sizeof(int) );
>> if( BigTable == NULL )
>> {
>> + free( K1table );
>
> It's good to fix leak on error path, but this condition is *impossible*: if
> BigTable was NULL, memset() above would die on SIGSEGV (and there are same
> problem with K1table allocation above) [and both really cries for
> "s/malloc/calloc/ and get rid of memset"]
> (Of course, this is a bug in libdvdcss, not something that should be fixed
> by
> this patch)
I assume this has been reported to libdvdcss?
More information about the MPlayer-dev-eng
mailing list