[MPlayer-dev-eng] Update libdvdcss to r255

Yuriy Kaminskiy yumkam at gmail.com
Sun Nov 4 20:47:47 CET 2012


Klaus Burton wrote:
> Here's another patch for review before I commit it, this one syncs libdvdcss to r255.
> Specifically, the changes are a memory leak fix (r239), assume a default drive type (r249) and support ELF visibility attribute (r255).
> 
> @@ -1188,6 +1188,7 @@
>      memset( BigTable, 0 , 16777216 * sizeof(int) );
>      if( BigTable == NULL )
>      {
> +        free( K1table );

It's good to fix leak on error path, but this condition is *impossible*: if
BigTable was NULL, memset() above would die on SIGSEGV (and there are same
problem with K1table allocation above) [and both really cries for
"s/malloc/calloc/ and get rid of memset"]
(Of course, this is a bug in libdvdcss, not something that should be fixed by
this patch)



More information about the MPlayer-dev-eng mailing list