[MPlayer-dev-eng] [PATCH] update ad_mpg123 in preparation to replace mp3lib

[compn]

On Wed, 14 Mar 2012 10:35:08 +0100, Diego Biurrun wrote:
>On Tue, Mar 13, 2012 at 10:24:16PM -0400, compn wrote:
>> On Tue, 13 Mar 2012 23:47:55 +0100, Thomas Orgis wrote:
>> >Am Tue, 13 Mar 2012 12:44:38 +0100
>> >schrieb Diego Biurrun <diego at biurrun.de>: 
>> >
>> >> Committed, thanks.
>> >
>> >Cool. How long should I wait to submit a patch that eliminates
>> >mp3lib, then, or do you manage that yourselves? ;-)
>> 
>> the first patch should be to put mpg123 ahead of ac mp3 in codecs.conf
>> by default. just to make sure it doesnt cause problems with any
>> samples or demuxers.
>> 
>> would be nice if we made it svn external or included a copy. i'm just
>> complaining since mac and mingw wont have a system mpg123...
>
>Nothing prevents those systems from having a system mpg123.

" 1. New installation via GNU autotools "

installing autotools is never fun. or easy.

(i wonder why step 2 is in the INSTALL at all?)
and 0. Prerequesites
does not list autotools crap at all!

>> before mp3lib is retired:
>> 1. make sure mpg123 builds on all systems mplayer builds on (amiga,
>> os/2 , arm, bsd, etc).
>> 
>> 2. run it on all of our mp3 samples , with ao pcm + md5 checking of
>> output. on all of those systems...
>
>Ugh, no, let's just dump it.

a better idea would be to have a distro dump it, so we can get bug
reports without affecting all users.

-compn