[MPlayer-dev-eng] [PATCH]Include stdlib from sdl_common.c

[Alexander Strasser]

Alexander Strasser wrote:
> Alexander Strasser wrote:
[...]
> > 
> >   Anyway I will commit the fix without the stdlib.h include removals
> > tomorrow evening. I think it is just too risky as things could subtly
> > break and that is not worth it for the removal of one include line.
> 
>   Committed.
> 
>   While testing I noticed that with #undef'ing the configure script was
> in conflict with osdep/setenv.h . This is why I propose the attached
> patch. I will apply it soon if I hear no objections.
> 
> diff --git a/configure b/configure
> index c9757b5..54b0587 100755
> --- a/configure
> +++ b/configure
> @@ -3961,7 +3961,7 @@ echocheck "setenv()"
>  setenv=yes
>  def_setenv='#define HAVE_SETENV 1'
>  statement_check stdlib.h 'setenv("", "", 0)' ||
> -    { setenv=no ; def_setenv='#undef HAVE_SETENV' ; }
> +    { setenv=no ; def_setenv='#define HAVE_SETENV 0' ; }
>  echores "$setenv"

  Committed this one too.

  Not sure if it would make sense to change at least the other
osdep/ related defines to use the same system. I see that we
overall have a mixed strategy for definng the HAVE_* macros:
some are defined to 1/0 and others are defined to 1 only and
undefined otherwise. I like defining to 1/0 better.


  Alexander