[MPlayer-dev-eng] [PATCH]Include stdlib from sdl_common.c
eclipse7 at gmx.net
Thu Jul 26 21:43:52 CEST 2012
Alexander Strasser wrote:
> Reimar Döffinger wrote:
> > On Wed, Jul 25, 2012 at 12:39:43AM +0200, Alexander Strasser wrote:
> > > Hi all,
> > >
> > > Reimar Döffinger wrote:
> > > > On 24 Jul 2012, at 09:35, Carl Eugen Hoyos <cehoyos at ag.or.at> wrote:
> > > > > sdl_common.c uses setenv() which needs stdlib.h.
> > > >
> > > > I believe that include belongs into osdep/setenv.h (not sure whether unconditionally or under if is better).
> > >
> > > I could not really test it as I guess things get pulled in from
> > > somewhere else on my system. But maybe attached patch is what you
> > > meant. I still need to double-check stdlib.h is not really needed
> > > for somthing else in those files.
> > If it works for fixing the issue and you double-check that the stdlib
> > removal is correct (or just don't remove them) that should be fine.
> Anyway I will commit the fix without the stdlib.h include removals
> tomorrow evening. I think it is just too risky as things could subtly
> break and that is not worth it for the removal of one include line.
While testing I noticed that with #undef'ing the configure script was
in conflict with osdep/setenv.h . This is why I propose the attached
patch. I will apply it soon if I hear no objections.
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 373 bytes
Desc: not available
More information about the MPlayer-dev-eng