[MPlayer-dev-eng] [PATCH] Play previously played entries in shuffled playlist

[Adam Buechler]

On Sun, Jul 15, 2012 at 4:25 PM, compn <tempn at twmi.rr.com> wrote:
> On Sun, 15 Jul 2012 14:43:54 -0400, Adam Buechler wrote:
>>Allows you to play previously played entries again in a shuffled playlist
>>by stepping backward in the playtree. It does this by shuffling the
>>playtree as you step through it, choosing a random song and swapping it
>>with the next entry every time you're about to step onto an entry that
>>hasn't been played before.
>>
>>It's kind of an ugly solution (can it even be called an iterator anymore if
>>it modifies the data structure as it iterates through it?), and I have a
>>feeling it might break anything that assumes that iterating through the
>>playtree won't change the playtree, so I understand if you don't want to
>>include the patch, but I've been using it for the past couple of weeks
>>without problems and it was a feature I missed a lot, so I just wanted to
>>share in case anyone else is interested.
>>
>>The patch is really small, so here it is:
>
>
> someone is touching the playlist code!

Hey, that's me!

>
> would you be interested in fixing it up? the automatic playlist
> detection has been disabled for years due to no one reviewing it for
> security problems.

Not really, but thank you for the offer. I don't think I'd be very
good at it, I've never been any good at thinking like a hacker.

>
> your patch means you can send a shuffle over and over and play forever?

I think you can already do that, if you pass -loop 0 along with the
-shuffle option.

>
> -compn
> _______________________________________________
> MPlayer-dev-eng mailing list
> MPlayer-dev-eng at mplayerhq.hu
> https://lists.mplayerhq.hu/mailman/listinfo/mplayer-dev-eng