[MPlayer-dev-eng] [PATCH] Play previously played entries in shuffled playlist

compn tempn at twmi.rr.com
Sun Jul 15 22:25:02 CEST 2012

On Sun, 15 Jul 2012 14:43:54 -0400, Adam Buechler wrote:
>Allows you to play previously played entries again in a shuffled playlist
>by stepping backward in the playtree. It does this by shuffling the
>playtree as you step through it, choosing a random song and swapping it
>with the next entry every time you're about to step onto an entry that
>hasn't been played before.
>It's kind of an ugly solution (can it even be called an iterator anymore if
>it modifies the data structure as it iterates through it?), and I have a
>feeling it might break anything that assumes that iterating through the
>playtree won't change the playtree, so I understand if you don't want to
>include the patch, but I've been using it for the past couple of weeks
>without problems and it was a feature I missed a lot, so I just wanted to
>share in case anyone else is interested.
>The patch is really small, so here it is:

someone is touching the playlist code!

would you be interested in fixing it up? the automatic playlist
detection has been disabled for years due to no one reviewing it for
security problems.

your patch means you can send a shuffle over and over and play forever?


More information about the MPlayer-dev-eng mailing list