[MPlayer-dev-eng] [PATCH] re_order: Be able to re-order 8 channels to AAC layout..

[Reimar Döffinger]

On Tue, Apr 24, 2012 at 10:24:39PM +0200, Tobias Diedrich wrote:
> Reimar Döffinger wrote:
> > On Wed, Apr 18, 2012 at 11:29:03AM -0700, Thierry Foucu wrote:
> > > Here is a patch will allow us to encode 7.1 audio AAC.
> > > 
> > > 7.1 audio not being really popular, instead of creating a new re_order
> > > function, I'm using 2 functions for the re_ordering from
> > > 
> > > L R Ls Rs C LFE Rls Rrs   -->  C L R Ls Rs Rls Rrs LFE
> > 
> > Seems fine to me if it works.
> > Though I'd put the } and the "else" on the same line.
> 
> The file is already inconsistent:

[...]

> So we could either submit this as-is (consistent with local style in
> the function) or update the file to be consistent with one of the
> three throughout.
> 
> Which would you prefer?

Doesn't matter then.
Any volunteers to commit or is everyone wanting me to do it?