[MPlayer-dev-eng] [PATCH] re_order: Be able to re-order 8 channels to AAC layout..

[Tobias Diedrich]

Reimar Döffinger wrote:
> On Wed, Apr 18, 2012 at 11:29:03AM -0700, Thierry Foucu wrote:
> > Here is a patch will allow us to encode 7.1 audio AAC.
> > 
> > 7.1 audio not being really popular, instead of creating a new re_order
> > function, I'm using 2 functions for the re_ordering from
> > 
> > L R Ls Rs C LFE Rls Rrs   -->  C L R Ls Rs Rls Rrs LFE
> 
> Seems fine to me if it works.
> Though I'd put the } and the "else" on the same line.

The file is already inconsistent:

Parts use

  if (bla) {
    foo;
  }
  else {
    bar;
  } 

others use

  if (bla)
    foo;
  else
    bar;

and yet other parts use

  if (bla) {
    foo;
  } else {
    bar;
  }

So we could either submit this as-is (consistent with local style in
the function) or update the file to be consistent with one of the
three throughout.

Which would you prefer?

Cheers,

-- 
Tobias						PGP: http://8ef7ddba.uguu.de