[MPlayer-dev-eng] [PATCH] GUI cursor control

[Ingo Brückl]

Reimar Döffinger wrote on Mon, 5 Sep 2011 19:32:24 +0200:

> On Mon, Sep 05, 2011 at 05:12:44PM +0200, Ingo Brückl wrote:
>> Reimar Döffinger wrote on Mon, 5 Sep 2011 16:55:19 +0200:
>>
>> > On Mon, Sep 05, 2011 at 12:05:28PM +0200, Ingo Brückl wrote:
>> >> Alexander Strasser wrote on Sun, 4 Sep 2011 20:21:08 +0200:
>> >> > Wouldn't it be better to have the X11 VOs not interfere with cursor
>> >> > management if an external WinID is used? In that case you would would be in
>> >> > control of it remaining invisible and responsible for making it visible.
>> >>
>> >> You mean something like the attached patch and having a mouse_autohide code
>> >> in GUI's wm/ws.c? Yes, this would really give full cursor control to the
>> >> application owning the WinID and I'm perfectly fine with this (solution #2),
>>
>> > Yes, I think this is a good way, though before you reimplement the autohide
>> > or similar functionality in the GUI
>>
>> I've already prepared and roughly checked this, it's only a few lines of
>> code.
>>
>> > it might make sense to move the check a bit so it's still possible to reuse
>> > the code if it makes sense.
>>
>> What do you mean by "move the check a bit", I don't get it. Which "check",
>> "move" where (or when)?

> Move the autohide timer check into a separate function, call that
> function from GUI.
> For that you'd have to move the WinID check into check_events instead
> of having it in hidecursor.

Oh, I see.

If you prefer this solution, I'm fine with it, although it seems more
complicated. We'd need a 1.patch to move the autohide into a separate
function, 2.patch to block it for WinIDs and 3.patch for the GUI to
implement autohide.

On the other hand, we could simply have a.patch to block WinIDs and a
b.patch for the GUI to implement autohide.

It's your call. What would you like?

Ingo
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 1.patch
Type: text/x-diff
Size: 2842 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20110906/25fcce56/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 2.patch
Type: text/x-diff
Size: 1641 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20110906/25fcce56/attachment-0001.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 3.patch
Type: text/x-diff
Size: 798 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20110906/25fcce56/attachment-0002.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: a.patch
Type: text/x-diff
Size: 848 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20110906/25fcce56/attachment-0003.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: b.patch
Type: text/x-diff
Size: 1388 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20110906/25fcce56/attachment-0004.bin>