[MPlayer-dev-eng] [PATCH] GUI cursor control

[Reimar Döffinger]

On Mon, Sep 05, 2011 at 05:12:44PM +0200, Ingo Brückl wrote:
> Reimar Döffinger wrote on Mon, 5 Sep 2011 16:55:19 +0200:
> 
> > On Mon, Sep 05, 2011 at 12:05:28PM +0200, Ingo Brückl wrote:
> >> Alexander Strasser wrote on Sun, 4 Sep 2011 20:21:08 +0200:
> >> > Wouldn't it be better to have the X11 VOs not interfere with cursor
> >> > management if an external WinID is used? In that case you would would be in
> >> > control of it remaining invisible and responsible for making it visible.
> >>
> >> You mean something like the attached patch and having a mouse_autohide code
> >> in GUI's wm/ws.c? Yes, this would really give full cursor control to the
> >> application owning the WinID and I'm perfectly fine with this (solution #2),
> 
> > Yes, I think this is a good way, though before you reimplement the autohide
> > or similar functionality in the GUI
> 
> I've already prepared and roughly checked this, it's only a few lines of
> code.
> 
> > it might make sense to move the check a bit so it's still possible to reuse
> > the code if it makes sense.
> 
> What do you mean by "move the check a bit", I don't get it. Which "check",
> "move" where (or when)?

Move the autohide timer check into a separate function, call that
function from GUI.
For that you'd have to move the WinID check into check_events instead
of having it in hidecursor.