[MPlayer-dev-eng] GUI's icon - a X11 issue?

[Steaphan Greene]

On 06/13/2011 04:13 PM, Ingo Brückl wrote:
> Steaphan Greene wrote on Mon, 13 Jun 2011 10:52:57 -0400:
> 
>> On 06/13/2011 06:27 AM, Ingo Brückl wrote:
>>>> +++ gui/wm/ws.c (working copy)
>>>> @@ -1253,7 +1253,7 @@
>>>>  void wsSetIcon( Display * dsp,Window win,Pixmap icon,Pixmap mask )
>>>>  {
>>>>   XWMHints * wm;
>>>> - long      data[2];
>>>> + uint32_t   data[2];
>>>
>>> Wouldn't it be better to use CARD32?
> 
>> Perhaps.  I stuck with the convention already in use in that .c file.
>> Other uint32_t and uint16_t types are already included elsewhere - in
>> the wsConvert() function.
> 
> All gui files are currently being revised, so new patches should alter into
> something as it should be, no matter what elsewhere in the file still might
> be wrong. Only after the revision following the "uncrustification" all
> nonconformances should have gone.

The "u?int[0-9]+_t" types are now the standard way to handle this in C,
so I tend to personally prefer them.  However, I am not the author of
this code, so, again, I really have no strong opinion on the matter.

-- 
Steaphan Greene <sgreene at cs.binghamton.edu>
Lecturer, Computer Science, Binghamton University
GPG public key: http://www.cs.binghamton.edu/~sgreene/gpg.key.txt