[MPlayer-dev-eng] GUI's icon - a X11 issue?

[Ingo Brückl]

Steaphan Greene wrote on Mon, 13 Jun 2011 10:52:57 -0400:

> On 06/13/2011 06:27 AM, Ingo Brückl wrote:
>>> +++ gui/wm/ws.c (working copy)
>>> @@ -1253,7 +1253,7 @@
>>>  void wsSetIcon( Display * dsp,Window win,Pixmap icon,Pixmap mask )
>>>  {
>>>   XWMHints * wm;
>>> - long      data[2];
>>> + uint32_t   data[2];
>>
>> Wouldn't it be better to use CARD32?

> Perhaps.  I stuck with the convention already in use in that .c file.
> Other uint32_t and uint16_t types are already included elsewhere - in
> the wsConvert() function.

All gui files are currently being revised, so new patches should alter into
something as it should be, no matter what elsewhere in the file still might
be wrong. Only after the revision following the "uncrustification" all
nonconformances should have gone.

Ingo