[MPlayer-dev-eng] patch for minor typos
Clément Bœsch
ubitux at gmail.com
Mon Jun 13 11:33:15 CEST 2011
On Fri, Jun 10, 2011 at 08:29:14AM -0700, Mike Castle wrote:
> On Fri, Jun 10, 2011 at 1:31 AM, Carl Eugen Hoyos <cehoyos at ag.or.at> wrote:
> > Applied without the first hunk.
>
> What was wrong with the first hunk? Not apply correct or disagreement?
>
> - // timestamp: HH:MM:SS.mmm, filepos: 0nnnnnnnnn
> + // timestamp: HH:MM:SS:mmm, filepos: 0nnnnnnnnn
>
> That is a correct change, as far as I can tell. The IDX files follow
> that format:
>
> timestamp: 00:00:01:401, filepos: 000000000
> timestamp: 00:00:03:370, filepos: 000000800
>
>
> and that's what the code below actually parses:
>
> 724 if (*p != ':')
> 725 return -1;
> 726 line = ++p;
> 727 while (isdigit(*p))
> 728 ++p;
> 729 if (p - line != 3)
> 730 return -1;
> 731 ms = atoi(line);
>
You were right; the comment is now dropped thought because of the sscanf
being clear enough.
--
Clément B.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 490 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20110613/e87d6f63/attachment.asc>
More information about the MPlayer-dev-eng
mailing list