[MPlayer-dev-eng] [PATCH] Fix Pause/Break Key

Steaphan Greene sgreene at cs.binghamton.edu
Sun Jun 12 21:16:47 CEST 2011


On 06/12/2011 02:07 PM, Diego Biurrun wrote:
> Looks good, I will apply after testing it.

Great, thanks.


> You brought down a huge monster 0.9kB patch down to 0.6kB.  I cannot
> imagine anybody suffering from such huge bandwidth concerns that 0.3kB
> is worth having to save the patch from your mail program, uncompress it
> externally, then look at it in some editor/pager instead of just look
> at it in your mail program where you are reading the mail anyway.

Heh, yeah.  It's rather pointless at this size, of course.  It's just
become my habit to compress anything text wherever possible, especially
when it will be replicated so many times.

I didn't consider anyone's mail GUI would not gunzip it automatically.
Now that I look at it, mine doesn't either.  I never noticed, since I'm
in the habit of opening all patches I get in gedit (I've become a slave
to syntax coloring), and txt.gz or .txt both work the same.

I'll leave them decompressed from now on, unless/until one is so large
that downloading it for review would be a requirement anyway.

Thanks for explaining.

-- 
Steaphan Greene <sgreene at cs.binghamton.edu>
Lecturer, Computer Science, Binghamton University
GPG public key: http://www.cs.binghamton.edu/~sgreene/gpg.key.txt


More information about the MPlayer-dev-eng mailing list