[MPlayer-dev-eng] [PATCH] Fix Pause/Break Key

Diego Biurrun diego at biurrun.de
Sun Jun 12 20:07:24 CEST 2011


On Fri, Jun 10, 2011 at 12:56:03PM -0400, Steaphan Greene wrote:
> On 06/10/2011 04:32 AM, Carl Eugen Hoyos wrote:
> > Steaphan Greene <sgreene <at> cs.binghamton.edu> writes:
> > 
> >> The (simple) attached patch fixes the pause/break key for X11 systems
> >> (in non-gui mode).  This makes it able to be bound as KEY_PAUSE, as I
> >> believe was intended.
> > 
> > Please consider sending uncompressed patches.
> 
> Ok.  The uncompressed version is attached.

Looks good, I will apply after testing it.

> Sorry, I didn't think compressing it would be anything but helpful.
> What is the problem/compication with sending compressed patches?

You brought down a huge monster 0.9kB patch down to 0.6kB.  I cannot
imagine anybody suffering from such huge bandwidth concerns that 0.3kB
is worth having to save the patch from your mail program, uncompress it
externally, then look at it in some editor/pager instead of just look
at it in your mail program where you are reading the mail anyway.

Diego


More information about the MPlayer-dev-eng mailing list