[MPlayer-dev-eng] [PATCH 1/3] Add mp_dir_join function.

[Clément Bœsch]

On Sat, Jan 29, 2011 at 02:34:34PM +0100, Reimar Döffinger wrote:
> On Sat, Jan 29, 2011 at 02:00:49PM +0100, Clément Bœsch wrote:
> > On Sat, Jan 29, 2011 at 01:51:18PM +0100, Reimar Döffinger wrote:
> > > On Sun, Jan 23, 2011 at 08:46:26PM +0100, Clément Bœsch wrote:
> > > > +    int dirlen = strlen(dir);
> > > > +    int i      = dirlen - 1;
> > > 
> > > 
> > > > +    if (i < 0 || dir[i] == '/')
> > > 
> > > I do not know if it really matters, but dirlen can be < 0.
> > 
> > You mean i?
> 
> No, I mean dirlen, for any string larger than 2GB.
> 

Oh my bad. Thanks for spotting it. Patch updated. Anything else?

-- 
Clément B.