[MPlayer-dev-eng] [PATCH 1/3] Add mp_dir_join function.

[Clément Bœsch]

On Sat, Jan 29, 2011 at 03:55:13PM +0100, Clément Bœsch wrote:
> On Sat, Jan 29, 2011 at 02:34:34PM +0100, Reimar Döffinger wrote:
> > On Sat, Jan 29, 2011 at 02:00:49PM +0100, Clément Bœsch wrote:
> > > On Sat, Jan 29, 2011 at 01:51:18PM +0100, Reimar Döffinger wrote:
> > > > On Sun, Jan 23, 2011 at 08:46:26PM +0100, Clément Bœsch wrote:
> > > > > +    int dirlen = strlen(dir);
> > > > > +    int i      = dirlen - 1;
> > > > 
> > > > 
> > > > > +    if (i < 0 || dir[i] == '/')
> > > > 
> > > > I do not know if it really matters, but dirlen can be < 0.
> > > 
> > > You mean i?
> > 
> > No, I mean dirlen, for any string larger than 2GB.
> > 
> 
> Oh my bad. Thanks for spotting it. Patch updated. Anything else?
> 
> -- 
> Clément B.

> From 0646cee083057abc305b5a29e1dad4ac9fe7b513 Mon Sep 17 00:00:00 2001
> From: =?UTF-8?q?Cl=C3=A9ment=20B=C5=93sch?= <ubitux at gmail.com>
> Date: Sun, 23 Jan 2011 19:23:54 +0100
> Subject: [PATCH 1/5] Add mp_dir_join function.

I'll commit this tuesday with second patch (overflow fix in subreader.c).

-- 
Clément B.