[MPlayer-dev-eng] the great reformatting

[Reimar Döffinger]

On Tue, Feb 15, 2011 at 09:11:15PM +0100, Clément Bœsch wrote:
> On Tue, Feb 15, 2011 at 09:00:48PM +0100, Reimar Döffinger wrote:
> > > > Why is a space added after a type conversion?
> > > >    (const void *const*)&index_data,
> > > > is changed to
> > > >    (const void *const *) &index_data,
> > > > or
> > > >   vo_vsync_time = GetTimer()-(int)((now-show_time)/1000);
> > > > is changed to
> > > >   vo_vsync_time = GetTimer() - (int) ((now - show_time) / 1000);
> > > > I think it is easier to read if type conversion is next to the data
> > > > being converted to show what is being converted.
> > > > 
> > > 
> > > I totally agree with this, but we should follow K&R.
> > 
> > I have seen absolutely no code that does this, so I very much
> > disagree here.
> 
> Disagree with what? I personally defend the no-space opinion for the same
> reason given above, but if so, it's an exception to K&R and should be
> written in the coding style rules.

I disagree with using that style with an extra space.
I am not against mentioning it, however
1) I doubt enough people know K&R is such detail that it really matters
2) Hopefully we can just say "look at almost any file, and if in doubt
   run uncrustify and you will see how it (probably) should look".
   We don't really want to bore people with a 50 page coding-style
   manual, people might feel reminded of EULAs and respond badly :-)