[MPlayer-dev-eng] [PATCH] More warnings

[Clément Bœsch]

On Tue, Feb 08, 2011 at 03:12:57PM +0100, Ingo Brückl wrote:
> Diego Biurrun wrote on Tue, 08 Feb 2011 01:52:00 +0100:
> 
> > +  cflag_check -Wcast-qual && WARN_CFLAGS="-Wcast-qual $WARN_CFLAGS"
> > +  cflag_check -Wwrite-strings && WARN_CFLAGS="-Wwrite-strings $WARN_CFLAGS"
> 
> I already commented these. If one wants to accept possible nuisances, they
> are fine.
> 
> > +  cflag_check -Wtype-limits && WARN_CFLAGS="-Wtype-limits $WARN_CFLAGS"
> 
> This is one (but only one) useful warning enabled by -Wextra.
> 
> I myself consider at least
> 
>   -Wempty-body
>   -Wsign-compare
>   -Wuninitialized
>   -Wunused-parameter
>   -Wswitch and -Wparentheses (from -Wall, but set -Wno...)
> 
> as a valuable help to avoid slips.
> 
> I'm not sure about -Wcast-align.
> 
> Ingo

Generally speaking, I'm personally ok adding ones, but then we should imo
not reject patch for silencing those warnings, even if they are stupid or
pointless from a functionnal point of view. I especially think of stuff
like signed/unsigned issue with sizeof, or adding (void) for unused
parameters like I already quoted.

Really, we don't need more warnings, we need more warning fixes…

-- 
Clément B.