[MPlayer-dev-eng] [PATCH] More warnings

[Ingo Brückl]

Diego Biurrun wrote on Tue, 08 Feb 2011 01:52:00 +0100:

> +  cflag_check -Wcast-qual && WARN_CFLAGS="-Wcast-qual $WARN_CFLAGS"
> +  cflag_check -Wwrite-strings && WARN_CFLAGS="-Wwrite-strings $WARN_CFLAGS"

I already commented these. If one wants to accept possible nuisances, they
are fine.

> +  cflag_check -Wtype-limits && WARN_CFLAGS="-Wtype-limits $WARN_CFLAGS"

This is one (but only one) useful warning enabled by -Wextra.

I myself consider at least

  -Wempty-body
  -Wsign-compare
  -Wuninitialized
  -Wunused-parameter
  -Wswitch and -Wparentheses (from -Wall, but set -Wno...)

as a valuable help to avoid slips.

I'm not sure about -Wcast-align.

Ingo