[MPlayer-dev-eng] [PATCH] win32 gui open disk for audio cd

[Reimar Döffinger]

On Wed, Dec 28, 2011 at 09:19:30PM +0100, Ingo Brückl wrote:
> Stephen,
> 
> are you using libcdio for audio cd playback?
> 
> If so, could you please check this patch which works with cdparanoia
> and Wine for me.

cdparanoia did not work for Windows back then when this was implemented I suspect.

> -#ifdef CONFIG_LIBCDIO
> +#if defined(CONFIG_LIBCDIO) || defined(CONFIG_CDDA)


Huh, what would be the point of this code when CONFIG_CDDA is set?
Or the other way round, why would CONFIG_LIBCDIO and not CONFIG_CDDA be
set?
I think this should just check for CONFIG_CDDA.
Except for the fact that CONFIG_CDDB might be enough, too.
Can't you just throw away all those ifdefs except for those in interface.c?
I think it should still compile fine and react reasonably even when cdda
support is missing.