[MPlayer-dev-eng] [PATCH] stream_cdda.c bugs and such

Ingo Brückl ib at wupperonline.de
Tue Dec 20 18:54:07 CET 2011


#1: option speed is checked by if(p->speed), so it should default to 0 rather
    than to -1

#2: p->sector has already been increased after buffer read, so now p->sector
    is the next sector to be read

#3: -1 is never a valid track

#4: allow PARANOIA_MODE_FULL with skipping

#5: don't set paranoia mode if nothing is requested
    (This actually fixes a bug where starting sectors for tracks are wrongly
    changed which caused the off-by-one issue for GET_NUM_CHAPTERS. TOC
    reading seems more reliable without calling it. The manpage advises
    against paranoia values as well.)

Ingo
-------------- next part --------------
A non-text attachment was scrubbed...
Name: cdda.bug1.patch
Type: text/x-diff
Size: 290 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20111220/1c6fb912/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: cdda.bug2.patch
Type: text/x-diff
Size: 515 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20111220/1c6fb912/attachment-0001.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: cdda.bug3.patch
Type: text/x-diff
Size: 424 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20111220/1c6fb912/attachment-0002.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: cdda.bug4.patch
Type: text/x-diff
Size: 452 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20111220/1c6fb912/attachment-0003.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: cdda.bug5.patch
Type: text/x-diff
Size: 547 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20111220/1c6fb912/attachment-0004.bin>


More information about the MPlayer-dev-eng mailing list