[MPlayer-dev-eng] [PATCH] stream_cdda.c bugs and such

[Reimar Döffinger]

On Tue, Dec 20, 2011 at 06:54:07PM +0100, Ingo Brückl wrote:
> #2: p->sector has already been increased after buffer read, so now p->sector
>     is the next sector to be read

Uh, yes. But I don't see what that has to do with what your patch does.
Previously it would print ID_CDDA_TRACK whenever the sector just read
belongs to the next track.
Now it would print that message with one sector delay (or, for playing
exactly one hypothetical one-sector track, never).

> #3: -1 is never a valid track

No, but -1 means "error". Your patch breaks the error case (e.g. broken
TOC) by always returning 0 then.

> #4: allow PARANOIA_MODE_FULL with skipping

Should be fine I guess. Not completely sure this is actually intended to
be used as a flag, I have a very hard time finding documentation.

> #5: don't set paranoia mode if nothing is requested
>     (This actually fixes a bug where starting sectors for tracks are wrongly
>     changed which caused the off-by-one issue for GET_NUM_CHAPTERS. TOC
>     reading seems more reliable without calling it. The manpage advises
>     against paranoia values as well.)

That doesn't make any sense to me at all.