[MPlayer-dev-eng] GUI and vo_x11_create_vo_window()

[Reimar Döffinger]

On Thu, Aug 18, 2011 at 10:57:10PM +0200, Ingo Brückl wrote:
> Reimar Döffinger wrote on Thu, 18 Aug 2011 22:28:10 +0200:
> 
> > On Thu, Aug 18, 2011 at 10:07:13PM +0200, Ingo Brückl wrote:
> >> Reimar Döffinger wrote on Thu, 18 Aug 2011 21:09:43 +0200:
> >> > Also, why not just set the already available global fullscreen variable?
> >>
> >> If I get it right that would be default for every (new) window, while the
> >> GUI else could start the next window (in a playlist) depending on the current
> >> state of the user's fullscreen button.
> 
> > I don't manage to make sense of this.
> 
> There is a button that says "fullscreen" (or normal window if not pressed).
> Assume you are starting fullscreen by default, then stop the video, press
> the button and start again. I would expect playback now in normal mode, not
> fullscreen, because I changed it. (I'm not quite sure about a playback of a
> new file though.)

I still do not see the difference in behaviour between the global
fullscreen variable and messing with the flags.

> > However you really shouldn't use it to mean fullscreen at all,
> 
> What "it"?

The fullscreen variable.

> > because with -wid there is no fullscreen, the concept makes no sense.
> 
> Since the -wid window isn't under MPlayer's control (well, actually it is,
> but it doesn't "belong" MPlayer), why shouldn't it be a fullscreen window?

"fullscreen" doesn't have any sensible meaning if the window isn't under your
control.

> >> Do you mean by "windowed_aspect_scaling option" a m_option_t option? If yes,
> >> I could try to prepare a patch proposal.
> 
> > Yes, though for your use case the point would be to have a global
> > variable with less annoying usage and semantics than the "fullscreen"
> > one.
> > And it probably should be accessed/modified from the gui via
> > get_property/set_property, since to do it properly the vo needs to be
> > notified when it is changed.
> 
> Ok, I'll think about it, but if you are ok with it, I'd like to start with
> gui(GUI_SETUP_VIDEO_WINDOW, &flags) to pass VOFLAG_FULLSCREEN (or not) to
> vo_x11_create_vo_window() which is exactly what MPlayer itself does.

Not really, it goes through the fullscreen global variable first.
And I don't see what you think the advantage of that flag manipulation
is.
If you fix mp_property_fullscreen so it works properly (by also taking
the fullscreen global into account) you can handle all cases with a
single mp_input_queue_cmd(mp_input_parse_cmd(...)).