[MPlayer-dev-eng] GUI and vo_x11_create_vo_window()

[Ingo Brückl]

Reimar Döffinger wrote on Thu, 18 Aug 2011 22:28:10 +0200:

> On Thu, Aug 18, 2011 at 10:07:13PM +0200, Ingo Brückl wrote:
>> Reimar Döffinger wrote on Thu, 18 Aug 2011 21:09:43 +0200:
>> > Also, why not just set the already available global fullscreen variable?
>>
>> If I get it right that would be default for every (new) window, while the
>> GUI else could start the next window (in a playlist) depending on the current
>> state of the user's fullscreen button.

> I don't manage to make sense of this.

There is a button that says "fullscreen" (or normal window if not pressed).
Assume you are starting fullscreen by default, then stop the video, press
the button and start again. I would expect playback now in normal mode, not
fullscreen, because I changed it. (I'm not quite sure about a playback of a
new file though.)

> However you really shouldn't use it to mean fullscreen at all,

What "it"?

> because with -wid there is no fullscreen, the concept makes no sense.

Since the -wid window isn't under MPlayer's control (well, actually it is,
but it doesn't "belong" MPlayer), why shouldn't it be a fullscreen window?

I agree, that there is a relation between fullscreen and aspect scaling
(getting aspect scaling in fullscreen for free) that is conceptionally
disputable.

BTW, vo_x11_create_vo_window() gets a VOFLAG_FULLSCREEN flag in case of -fs,
so the gui(GUI_SETUP_VIDEO_WINDOW, &flags) hack doesn't seem to be so bad at
all.

>> Do you mean by "windowed_aspect_scaling option" a m_option_t option? If yes,
>> I could try to prepare a patch proposal.

> Yes, though for your use case the point would be to have a global
> variable with less annoying usage and semantics than the "fullscreen"
> one.
> And it probably should be accessed/modified from the gui via
> get_property/set_property, since to do it properly the vo needs to be
> notified when it is changed.

Ok, I'll think about it, but if you are ok with it, I'd like to start with
gui(GUI_SETUP_VIDEO_WINDOW, &flags) to pass VOFLAG_FULLSCREEN (or not) to
vo_x11_create_vo_window() which is exactly what MPlayer itself does.

Ingo