[MPlayer-dev-eng] [PATCH] fix dvdnav multi-cell menus

[Steaphan Greene]

On 08/17/2011 08:27 AM, Carl Eugen Hoyos wrote:
> Steaphan Greene <sgreene <at> cs.binghamton.edu> writes:
> 
>> As for the separation of white-space changes, does that really include
>> cases like this, where the white-space changes are a direct result of a
>> functional change (removal the else {} block)?
> 
> It could even be argued that the case you describe is the only reason for the
> rule in question.
> As far as MPlayer and FFmpeg are concerned, you may leave the re-indentation to
> the committer (although a second whitespace patch doesn't hurt).

I see.  That actually does make a lot of sense.  It's just a different
paradigm then I'm used to for patch submissions
(review-then-implement-based-on -vs- review-then-apply).  I will submit
patches using svn diff with "-x -w" from now on, where appropriate.

Thanks.

-- 
Steaphan Greene <sgreene at cs.binghamton.edu>
Lecturer, Computer Science, Binghamton University
GPG public key: http://www.cs.binghamton.edu/~sgreene/gpg.key.txt