[MPlayer-dev-eng] [PATCH] vf_ffmpeg, threads and slice callback

[Michael Niedermayer]

On Wed, Jul 14, 2010 at 12:32:20AM +0200, Reimar Döffinger wrote:
> On Tue, Jul 13, 2010 at 11:24:14PM +0200, Adrian Stutz wrote:
> > Hello,
> > 
> > This patch originates from this discussion on mplayer-users:
> > http://lists.mplayerhq.hu/pipermail/mplayer-users/2009-December/078410.html
> > http://lists.mplayerhq.hu/pipermail/mplayer-users/2010-January/078845.html
> > 
> > Basically, using a ffmpeg decoder that supports slices with multiple
> > threads leads to serious video corruption (e.g. when playing DVDs).
> > 
> > I can reproduce the issue with this command line (see the above thread
> > for more info):
> > mplayer -lavdopts threads=4 dvd:////path/to/VIDEO_TS
> > 
> > I cherry picked this patch from the fix Utoi applied to his unofficial
> > git branch.
> > 
> > There's also a much less educated patch from me in this post:
> > http://lists.mplayerhq.hu/pipermail/mplayer-users/2010-January/078851.html
> > 
> > Is this ok to apply?
> 
> The do_dr1 part should only apply to ffmpeg-mt and should only needlessly
> slow things down for normal FFmpeg.
> Also a good question is why exactly slices fail with multiple threads...

the draw slice callback being called at the same time from multiple threads
maybe ...
for example the scale filter will blow up with that input

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

No great genius has ever existed without some touch of madness. -- Aristotle
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20100911/5af17b5a/attachment.pgp>