[MPlayer-dev-eng] mp3lib costab_mmx type mismatch

Diego Biurrun diego at biurrun.de
Sat Sep 11 17:02:52 CEST 2010


costab_mmx is declared/used with different types in mp3lib.  The original
declaration is

mp3lib/decode_mmx.c:const unsigned int __attribute__((aligned(16))) costab_mmx[] =

but there is an extern reference to it with a float type:

mp3lib/dct64_sse.c:extern float __attribute__((aligned(16))) costab_mmx[];

Just changing the type in the extern declaration generates the following
warnings:

mp3lib/dct64_sse.c:30: warning: initialization from incompatible pointer type
mp3lib/dct64_sse.c:88: warning: initialization from incompatible pointer type
mp3lib/dct64_sse.c:116: warning: initialization from incompatible pointer type

Since this is in asm code, I have no idea if the change would be correct
or safe.  Can anybody shine a light on this?

Diego


More information about the MPlayer-dev-eng mailing list