[MPlayer-dev-eng] [PATCH] Capture feature

[Reimar Döffinger]

On Fri, Sep 03, 2010 at 03:24:13PM +0200, Pásztor Szilárd wrote:
> Reimar Döffinger:
> > I don't really like that design.
> > Can't you put the FILE * in the stream struct?
> 
> Despite my initial objections, I implemented it on a
> one-by-stream basis. Now a separate dumpfile is generated
> for each parallel stream, with automatically numbered file
> names if needed.

Sorry that I was unclear. I didn't mean for you to implement
this feature, I was just explaining why it is better to
have it in the stream struct.
This approach ends up with more global variables, I was rather
hoping to keep the stream layer clean from that.
I don't know if/how this is possible, but my idea was for the
command.c code to open/close the file and set the FILE *
within the stream appropriately, and not having any logic
beyond
if (capture_file) fwrite(...);
in the stream layer...