[MPlayer-dev-eng] [PATCH] Capture feature

Pásztor Szilárd bartosteka at freemail.hu
Sun Sep 5 14:01:34 CEST 2010


Reimar Döffinger:
> Sorry that I was unclear. I didn't mean for you to implement
> this feature, I was just explaining why it is better to have it in the stream struct.
> This approach ends up with more global variables, I was rather
> hoping to keep the stream layer clean from that.
> I don't know if/how this is possible, but my idea was for the
> command.c code to open/close the file and set the FILE *
> within the stream appropriately, and not having any logic
> beyond if (capture_file) fwrite(...);
> in the stream layer...

Here I attach a simpler version where only the primary stream
gets dumped again (it doesn't make much sense to make things
more complicated than that). No bumming global variables and
no extensive logic in the stream beyond writing.

p.s. any objections against applying the nocorrect-pts patch?
-------------- next part --------------
A non-text attachment was scrubbed...
Name: mplayer-2010-09-05-capture.diff
Type: application/octet-stream
Size: 9287 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20100905/4d352dca/attachment.obj>


More information about the MPlayer-dev-eng mailing list