[MPlayer-dev-eng] [PATCH] -force-key-frames option

[Reimar Döffinger]

On Sun, Oct 17, 2010 at 09:59:26PM +0200, Nicolas George wrote:
> Le sextidi 26 vendémiaire, an CCXIX, Reimar Döffinger a écrit :
> > Possibly a bit silly, since you'd have to validate the values separately,
> > but have you considered using CONF_TYPE_STRING_LIST instead and doing
> > the parsing inside is_forced_key_frame?
> 
> I think that would be very awkward code. Furthermore, as a user I would
> rather have a typo in the last timestamp detected immediately rather than
> after several hours.

That's why I said "validate the values separately". I.e. run a function that
checks them right after option parsing.

> As a side note, the parsing functions returns M_OPT_INVALID just like
> dvd_parse_chapter_range, but it does not seem to have any effect at all. Is
> this normal?

Could you be more specific? I'm a bit unsure what exactly you mean.

> +int parse_forced_key_frames(const m_option_t *opt, char *arg)

And I just checked the m_option code: the arg argument should be
"const char *"