[MPlayer-dev-eng] [PATCH] -force-key-frames option

[Nicolas George]

Le sextidi 26 vendémiaire, an CCXIX, Reimar Döffinger a écrit :
> [in] is a bit pointless for non-pointer arguments (what else could they be
> after all?).

Indeed, but I find it globally more readable if the [in]/[out] tag is there
everywhere or not at all.

> "first frame", not "frames"
> "can be used" instead of "useful" I'd suggest.

Changed.

> Possibly a bit silly, since you'd have to validate the values separately,
> but have you considered using CONF_TYPE_STRING_LIST instead and doing
> the parsing inside is_forced_key_frame?

I think that would be very awkward code. Furthermore, as a user I would
rather have a typo in the last timestamp detected immediately rather than
after several hours.

As a side note, the parsing functions returns M_OPT_INVALID just like
dvd_parse_chapter_range, but it does not seem to have any effect at all. Is
this normal?

> The validating could also include checking the values are actually
> in increasing order.

Done.

> Maybe also set forced_key_frames_number to 0 just in case?

Done.

Regards,

-- 
  Nicolas George
-------------- next part --------------
A non-text attachment was scrubbed...
Name: mplayer-forcekeyframes-20101017-2152-01-parser.diff
Type: text/x-diff
Size: 2646 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20101017/3ec14cab/attachment-0005.diff>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: mplayer-forcekeyframes-20101017-2152-02-option.diff
Type: text/x-diff
Size: 4657 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20101017/3ec14cab/attachment-0006.diff>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: mplayer-forcekeyframes-20101017-2152-03-lavc.diff
Type: text/x-diff
Size: 1253 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20101017/3ec14cab/attachment-0007.diff>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: mplayer-forcekeyframes-20101017-2152-04-x264.diff
Type: text/x-diff
Size: 1050 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20101017/3ec14cab/attachment-0008.diff>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: mplayer-forcekeyframes-20101017-2152-05-xvid.diff
Type: text/x-diff
Size: 1190 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20101017/3ec14cab/attachment-0009.diff>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20101017/3ec14cab/attachment-0001.pgp>