[MPlayer-dev-eng] [PATCH 1/7] Unescape login/password before base64 encode

[Clément Bœsch]

On Sun, Oct 24, 2010 at 09:40:00PM +0200, Clément Bœsch wrote:
> On Sun, Oct 24, 2010 at 09:12:37PM +0200, Reimar Döffinger wrote:
> > On Sun, Oct 24, 2010 at 09:07:50PM +0200, Clément Bœsch wrote:
> > > On Sun, Oct 24, 2010 at 08:31:06PM +0200, Reimar Döffinger wrote:
> > > > On Sun, Oct 24, 2010 at 08:10:00PM +0200, Clément Bœsch wrote:
> > > > > On Mon, Oct 18, 2010 at 12:05:51PM +0200, Clément Bœsch wrote:
> > > > > > I already sent it in a previous mail: it allows login/password to be
> > > > > > unescaped before base64 encode so auth with special characters now
> > > > > > works.
> > > > > 
> > > > > Still no news about this first patch; it should not require a lot of
> > > > > skills to review this stuff, even if it's 8 patches. Can anyone do it, or
> > > > > at least start with this one please? Those bugs are really annoying and
> > > > > easy to fix…
> > > > 
> > > > It's not at all easy to figure out if they actually fix more or break more...
> > > > This first patch for example I don't think anyone who has a %-sign in the
> > > > password will like.
> > > > Does e.g. Firefox really try to unescape the password?
> > > 
> > > The unescape is done because the URL is url-encoded in MPlayer (and so
> > > login/password). '%' seems to work:
> > > 
> > > % ./mplayer 'http_proxy://login_x:a%b%c@localhost:8123/http://localhost:8000
> > > [...]
> > 
> > Hm, ok, however I suspect that the whole escaping
> > handling in MPlayer is rather broken so I am not sure if
> > this is more a way of fixing things or if it's more kind of
> > adding a bug to hide the other bug that will make other
> > fixes more difficult...
> 
> ok, then here is the updated patch but with the two "cosmetics" patches
> you requested to have before.
> 

Is it OK to commit at least the first two ones (allocation string and
256 to sizeof) so we can focus on the real issue?

-- 
Clément B.
Not sent from a jesusPhone.