[MPlayer-dev-eng] [PATCH] -vo lavf

[Nicolas George]

Le septidi 17 brumaire, an CCXIX, Reimar Döffinger a écrit :
> I'd prefer you didn't, I'd prefer to save myself having to think
> if there might be any compatibilty issue with some calling conventions.

Ok. What about adding a pts field to mp_image_t?

> Also, while it is a hack there is already a vo_pts variable.

Unfortunately, it is fed by the timestamp from the demuxer, while video
filters can add or remove frames.

> Lastly, I miss the most important information: why?
> What is the big advantage over using mencoder?

Half the times when someone ask something about mencoder, the answer is
"mencoder is unmaintained, use ffmpeg instead". And this is not wrong: I
remember the time it took to bring ASS support from mplayer to mencoder, and
I understand that there are still features that are not in sync. And let us
not forget that mencoder can not mux keyframes in most formats.

> I'm sure there are already several functions that do that kind
> of parsing, I'd prefer not to have yet another one.

They were not available. I'll try to factorize.

> Wasn't this FFmpeg initialization code moved to some common code or something?

I thought so, but the place I looked did not use it. I'll check again.

> I consider a goto vastly preferable over this code-quituplication...

Ok.

Regards,

-- 
  Nicolas George
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20101107/1692b27d/attachment-0001.pgp>