[MPlayer-dev-eng] [PATCH] Fix return values of WaitForSingleObject when checking an event

Steinar H. Gunderson sgunderson at bigfoot.com
Wed Mar 3 23:13:38 CET 2010


On Wed, Mar 03, 2010 at 08:11:48PM +0100, Reimar Döffinger wrote:
> As you have probably noticed, my reviews are basically the bottleneck,
> though luckily you are not that easily discouraged.
> So (assuming no other developers have objections) I propose the following:
> - you get an SVN account and become the maintainer of the loader code,
>   if I don't review something within a few days you can commit it (or if
>   it's trivial you can commit directly).

Hm, OK. I wasn't really prepared for that answer, but if it's what it takes,
I think I can do a reasonable job. :-)

> In exchange, you try to reasonably test your changes with several other codecs
> (I think VP*, real and some Quicktime stuff might be relevant), try to be around
> if issues come up due to your changes.

Sure; I guess that's what comes with being a maintainer.

I guess there's no automated test suite here, so you can easily test that
your changes don't break anything important? (Did I just volunteer to make one? :-/)

> And of course, read DOCS/tech/svn-howto.txt and agree with the spirit of the rules
> explained in there.

Read and accepted.

> If that's all the case, the process would be to send Diego a GPG-encrypted email
> with the username and password you want.

What's his e-mail address?

> And while that account seems to no longer come with an FFmpeg account, keep in mind
> that libswscale nowadays belongs to FFmpeg, in case you ever want to do changes there.

I guess I'll stay out of libswscale, so no big problem there.

/* Steinar */
-- 
Homepage: http://www.sesse.net/



More information about the MPlayer-dev-eng mailing list