[MPlayer-dev-eng] [PATCH] Fix return values of WaitForSingleObject when checking an event

[Reimar Döffinger]

On Wed, Mar 03, 2010 at 11:13:38PM +0100, Steinar H. Gunderson wrote:
> On Wed, Mar 03, 2010 at 08:11:48PM +0100, Reimar Döffinger wrote:
> > As you have probably noticed, my reviews are basically the bottleneck,
> > though luckily you are not that easily discouraged.
> > So (assuming no other developers have objections) I propose the following:
> > - you get an SVN account and become the maintainer of the loader code,
> >   if I don't review something within a few days you can commit it (or if
> >   it's trivial you can commit directly).
> 
> Hm, OK. I wasn't really prepared for that answer, but if it's what it takes,
> I think I can do a reasonable job. :-)

Not that it's necessary, but we are short on people and I think you're the only
one in a long time doing some significant work on the loader and I don't remember
serious issues with any of your patches.

> > In exchange, you try to reasonably test your changes with several other codecs
> > (I think VP*, real and some Quicktime stuff might be relevant), try to be around
> > if issues come up due to your changes.
> 
> Sure; I guess that's what comes with being a maintainer.
> 
> I guess there's no automated test suite here, so you can easily test that
> your changes don't break anything important? (Did I just volunteer to make one? :-/)

Unfortunately nothing in MPlayer has any test suite. Since we're all too lazy the solution
to this is trying to push as much as possible into FFmpeg :-)
In the end, users will report if you broke something, it's just that with the loader code
even "obviously correct" code can break something so it better shouldn't be tested with
only one codec.

> > If that's all the case, the process would be to send Diego a GPG-encrypted email
> > with the username and password you want.
> 
> What's his e-mail address?

diego at biurrun.de

Reimar