[MPlayer-dev-eng] [PATCH] Tags support for SubRip and MicroDVD subtitles [v3]

[Kazuo Teramoto]

On Wed, Jun 23, 2010 at 6:10 AM, ubitux <ubitux at gmail.com> wrote:
> 29%… Well then I think it's the best argument you can give, so ok then. I
> didn't know it was so common… But maybe I'll check it too.
>

Haha, as a physicist, numbers are the best argument =]

After some sleep I'm gonna to a more rigorousness tests.

>> wrong hex color : 2 (2% of font) [color=CCFF00]
>
> Do you think we should try to handle that too?

I don't think we should, because they are wrong defined. My opinion is
to treat then as a wrong tag, i.e. display they unmodified so the user
can "file a bug report" against the subtitles maker (and, I hope, not
against mplayer...).

But at current state is not hard to handle then I think and they are
not ambiguous. Current the only accepted colors are hex colors
(triplets of pair of hex numbers) and 16 named web colors, none of
named colors are valid hex numbers triplets, so one approach is try to
parse the attribute value as a hex color if this fail parse as named
color, but if in the future we add more colors this can break down.

>
> But maybe we should wait for the first one to be applied: the patch is
> going bigger and bigger and not easy to review. So ok, I'll do that as
> soon as the first one is applied. Maybe I'll send patches to the Uoti's
> git repository since it's easier to stack patches.
>

Agreed, better to develop this in stages. The current status is *very*
good, from my "analysis" 99.91% of common SubRip tags are correct
rendered, so I think that this improvement fall on Knuth's premature
optimizations quote.

Regards,
Kazuo

-- 
«Dans la vie, rien n'est à craindre, tout est à comprendre»
Marie Sklodowska Curie.