[MPlayer-dev-eng] [PATCH] Tags support for SubRip and MicroDVD subtitles [v3]

[ubitux]

On Wed, Jun 23, 2010 at 05:54:59AM -0300, Kazuo Teramoto wrote:
> I downloaded 1014 random SubRip subs from opensubtitles.org this is
> the tag "analysis":
> 
> total lines     : 3891050
> total tags      : 30284
> <i> tags        : 28881
> <u> tags        : 1000
> <b> tags        : 306
> <s> tags        : 0
> <font> tags     : 97
> unquoted attr   : 28 (29% of font) [things like size=10 or color=#ffff00]

huh? what? oO

29%… Well then I think it's the best argument you can give, so ok then. I
didn't know it was so common… But maybe I'll check it too.

> wrong hex color : 2 (2% of font) [color=CCFF00]

Do you think we should try to handle that too?

> spaced attr     : 0 [color   =   blue]
> single quotes   : 0 [color='blue']
> 

\o/

> So I think that adding support for unquoted not spaced valid
> attributes is a must have. What you think?
> 

I agree now :)

But maybe we should wait for the first one to be applied: the patch is
going bigger and bigger and not easy to review. So ok, I'll do that as
soon as the first one is applied. Maybe I'll send patches to the Uoti's
git repository since it's easier to stack patches.

> Regards,
> Kazuo
> 

Regards,

-- 
ubitux