[MPlayer-dev-eng] [PATCH] latm faad handling

Diego Biurrun diego at biurrun.de
Mon Jun 21 18:42:37 CEST 2010


On Mon, Jun 21, 2010 at 06:14:57PM +0200, Dan Oscarsson wrote:
> On 2010-06-18 at 11:23 +0200 Diego Biurrun wrote:
> > > --- libmpdemux/demux_ts.c.org	2010-06-12 17:25:59.080522959 +0200
> > > +++ libmpdemux/demux_ts.c	2010-06-12 17:28:45.068522513 +0200
> > > @@ -246,7 +247,7 @@
> > >  
> > >  
> > > -#define IS_AUDIO(x) (((x) == AUDIO_MP2) || ((x) == AUDIO_A52) || ((x) == AUDIO_LPCM_BE) || ((x) == AUDIO_AAC) || ((x) == AUDIO_DTS) || ((x) == AUDIO_TRUEHD))
> > > +#define IS_AUDIO(x) (((x) == AUDIO_MP2) || ((x) == AUDIO_A52) || ((x) == AUDIO_LPCM_BE) || ((x) == AUDIO_AAC) || ((x) == AUDIO_DTS) || ((x) == AUDIO_TRUEHD) || ((x) == AUDIO_AAC_LATM))
> > 
> > You could break this long line while you're at it..
> 
> I could, but the file contains a few long lines like that at that place,
> so all should be broken at the same time, so maybe that should be
> patched separately. I thought that was cosmetics.

It's just a suggestion.

Since you are touching the line anyway, you might as well break it.
This is not considered cosmetics.

Diego



More information about the MPlayer-dev-eng mailing list