[MPlayer-dev-eng] [PATCH]Increase MAX_CARDS in stream/stream_dvb.c

Nico Sabbi nicola.sabbi at poste.it
Fri Jul 30 15:16:46 CEST 2010


Reimar Döffinger ha scritto:
> On Thu, Jul 08, 2010 at 12:00:02AM +0200, Carl Eugen Hoyos wrote:
>    
>> Nico, any objections?
>>
>> Carl Eugen
>>      
>    
>> Index: stream/stream_dvb.c
>> ===================================================================
>> --- stream/stream_dvb.c	(revision 31644)
>> +++ stream/stream_dvb.c	(working copy)
>> @@ -50,6 +50,7 @@
>>   #include "dvbin.h"
>>
>>
>> +#define MAX_CARDS 8
>>      
> That name is too generic there.
> Also I'm not sure if it isn't better to allow any value in
> the parser and print the right error elsewhere with an info
> what to change (there's also the question why we have to
> limit the number of supported cards at all).
>
>    

If I'm not mistaken  in V3 API there's a limit on the number of usable 
cards, but at most the
calls to open() will fail, so no objection by me.
The reason it's static is to avoid some boring malloc()s ;-)


More information about the MPlayer-dev-eng mailing list