[MPlayer-dev-eng] [PATCH]Increase MAX_CARDS in stream/stream_dvb.c

[Reimar Döffinger]

On Fri, Jul 30, 2010 at 03:16:46PM +0200, Nico Sabbi wrote:
> Reimar Döffinger ha scritto:
> >On Thu, Jul 08, 2010 at 12:00:02AM +0200, Carl Eugen Hoyos wrote:
> >>Nico, any objections?
> >>
> >>Carl Eugen
> >>Index: stream/stream_dvb.c
> >>===================================================================
> >>--- stream/stream_dvb.c	(revision 31644)
> >>+++ stream/stream_dvb.c	(working copy)
> >>@@ -50,6 +50,7 @@
> >>  #include "dvbin.h"
> >>
> >>
> >>+#define MAX_CARDS 8
> >That name is too generic there.
> >Also I'm not sure if it isn't better to allow any value in
> >the parser and print the right error elsewhere with an info
> >what to change (there's also the question why we have to
> >limit the number of supported cards at all).
> >
> 
> If I'm not mistaken  in V3 API there's a limit on the number of
> usable cards, but at most the
> calls to open() will fail, so no objection by me.
> The reason it's static is to avoid some boring malloc()s ;-)

Sorry, I misread my patch, I withdraw any objections.
And Nico doesn't seem to have any either.
Obviously it is possible to do this in a better way, but
please apply the patch since it is an improvement either way.