[MPlayer-dev-eng] [PATCH] Get Demuxer Time for Proper DVD Time REDUX

[Paul Huwe]

Quick followup on timing:

I tested on several DVDs, and get_demux_time_pos (rounded to 100 ms) matched the time from get_time_pos until get_time_pos resets, so.. I feel it is an accurate time.

Cheers,
Paul



--- On Fri, 7/16/10, Paul Huwe <reicow at yahoo.com> wrote:

> From: Paul Huwe <reicow at yahoo.com>
> Subject: Re: [MPlayer-dev-eng] [PATCH] Get Demuxer Time for Proper DVD Time REDUX
> To: mplayer-dev-eng at mplayerhq.hu
> Date: Friday, July 16, 2010, 2:48 AM
> > First, the name is rather bad,
> it is the stream time, not
> > the demuxer time.
> > The demuxer is only involved because there might be a
> lot
> > of packets buffer
> > and thus the time stamps need to be buffered along
> with
> > them.
> 
> I have no issue with renaming either the function or slave
> command/etc.
> 
> > And the time is probably still off a bit.
> 
> This can easily be corrected for by some offset after the
> fact, no?
> 
> > Also, for this kind of thing it is much preferable to
> > provide it via get_property.
> > (see mp_properties table in command.c).
> 
> Umm, okay. How does one extract mp_property elements via
> the slave interface? (Or am I misunderstanding you?)
> 
> > Lastly, I have some doubts about doing a fallback:
> first,
> > as you do it it is incomplete,
> > failing for audio-only. It also discards the
> information
> > whether a stream pts is
> > available, which makes the difference between
> > reliable/non-warp-around timestamps
> > (DVD) or not (playing the same vob after copying it
> from
> > the DVD).
> 
> Okay.. do you have a suggestion for what needs to be done
> here for codebase implementation? Frankly, I only really
> cared about getting a (at least somewhat) proper time from
> DVDs... some alternative to get_time_pos to help with dvd
> timing/seekbar timing/etc.. I'm just trying to get a slave
> accessible, sub second, stream time into the mplayer
> codebase.
> 
> Thanks,
> Paul
> 
> 
> 
> 
>       
> 
> _______________________________________________
> MPlayer-dev-eng mailing list
> MPlayer-dev-eng at mplayerhq.hu
> https://lists.mplayerhq.hu/mailman/listinfo/mplayer-dev-eng
>