[MPlayer-dev-eng] [PATCH] Get Demuxer Time for Proper DVD Time REDUX

[Paul Huwe]

> First, the name is rather bad, it is the stream time, not
> the demuxer time.
> The demuxer is only involved because there might be a lot
> of packets buffer
> and thus the time stamps need to be buffered along with
> them.

I have no issue with renaming either the function or slave command/etc.

> And the time is probably still off a bit.

This can easily be corrected for by some offset after the fact, no?

> Also, for this kind of thing it is much preferable to
> provide it via get_property.
> (see mp_properties table in command.c).

Umm, okay. How does one extract mp_property elements via the slave interface? (Or am I misunderstanding you?)

> Lastly, I have some doubts about doing a fallback: first,
> as you do it it is incomplete,
> failing for audio-only. It also discards the information
> whether a stream pts is
> available, which makes the difference between
> reliable/non-warp-around timestamps
> (DVD) or not (playing the same vob after copying it from
> the DVD).

Okay.. do you have a suggestion for what needs to be done here for codebase implementation? Frankly, I only really cared about getting a (at least somewhat) proper time from DVDs... some alternative to get_time_pos to help with dvd timing/seekbar timing/etc.. I'm just trying to get a slave accessible, sub second, stream time into the mplayer codebase.

Thanks,
Paul