[MPlayer-dev-eng] [RFC] HRTF filter revision

Diego Biurrun diego at biurrun.de
Wed Jul 14 10:30:30 CEST 2010


On Tue, Jul 13, 2010 at 06:40:06PM -0400, Yue Shi Lai wrote:
>
> Attached is a snapshot of what I would like to propose as a revised HRTF  
> filter. I would appreciate any comment or criticism.

Quick note: Please use 4 spaces indentation.

> --- Makefile	(revision 31733)
> +++ Makefile	(working copy)
> @@ -20,6 +20,7 @@
>  
>  include config.mak
> +EXTRALIBS += -lrt

This is not allowed.

> --- libaf/af_hrtf.c	(revision 31733)
> +++ libaf/af_hrtf.c	(working copy)
> +static inline void
> +apply_amplitude_delay(float *amplitude, int *delay,
> +					  const float *system_amplitude,
> +					  const size_t *system_delay)

Keep the function declaration on one line and align the arguments.

Diego


More information about the MPlayer-dev-eng mailing list