[MPlayer-dev-eng] [PATCH] enable robust resync for mpg123 decoder

Thomas Orgis thomas-forum at orgis.org
Sun Jul 11 19:25:41 CEST 2010


Hi,

attached patch enables endless resync for ad_mpg123, which prevents the
decoder from giving up on long pieces of invalid stream data (like when
having bad reception for DVB-T). That case would be rather fatal, as
MPlayer ignores the error state of the audio decoder and gets stuck
(instead of trying to reopen the decoder, for example, or just quitting
with a decoding error).

Anyway, mpg123 can deal with such streams, it just needs to be told
that it should never stop trying to parse, however much invalid data
came through.


Alrighty then,

Thomas.

PS: Diego, the #ifdef cruft in the file may be cleared up by dropping
AD_MPG123_CALLBACK and AD_MPG123_SEEKBUFFER, accordingly. I do not see
that much influence of the data input method on performance and the
default way is the most compatible. But still, before dropping the
cruft, I really would like to have found the reason for the rather
unusual performance hit MPlayer experiences compared to plain mpg123,
using the same decoding library.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: mplayer-mpg123-resync.patch
Type: text/x-patch
Size: 665 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20100711/ada4bcae/attachment-0001.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20100711/ada4bcae/attachment-0001.pgp>


More information about the MPlayer-dev-eng mailing list