[MPlayer-dev-eng] [PATCH] enable robust resync for mpg123 decoder

Diego Biurrun diego at biurrun.de
Tue Jul 13 17:12:29 CEST 2010


On Sun, Jul 11, 2010 at 07:25:41PM +0200, Thomas Orgis wrote:
> 
> attached patch enables endless resync for ad_mpg123, which prevents the
> decoder from giving up on long pieces of invalid stream data (like when
> having bad reception for DVB-T). That case would be rather fatal, as
> MPlayer ignores the error state of the audio decoder and gets stuck
> (instead of trying to reopen the decoder, for example, or just quitting
> with a decoding error).

Thanks, applied.

> PS: Diego, the #ifdef cruft in the file may be cleared up by dropping
> AD_MPG123_CALLBACK and AD_MPG123_SEEKBUFFER, accordingly. I do not see
> that much influence of the data input method on performance and the
> default way is the most compatible. But still, before dropping the
> cruft, I really would like to have found the reason for the rather
> unusual performance hit MPlayer experiences compared to plain mpg123,
> using the same decoding library.

What do you want me to investigate exactly?

Diego


More information about the MPlayer-dev-eng mailing list