[MPlayer-dev-eng] simple Blu-ray playback [Patch]

[Diego Biurrun]

On Fri, Jul 02, 2010 at 11:09:00AM +0200, Alexander Roalter wrote:
> 
> --- stream/stream_bd.c	(revision 0)
> +++ stream/stream_bd.c	(revision 0)
> @@ -0,0 +1,349 @@
> +    if (file == 0) {

!file - not that it's particularly important.

> +        mp_msg(MSGT_OPEN, MSGL_ERR, 
> +            "Cannot open file %s to get UK and DiscID\n", filename);

Indentation is messed up here, the function arguments should be
aligned.

> +        if (memcmp(id, discid, 20) != 0) continue;

Please place statements after conditions on the next line.

> +            if (key_pos + 16 <= file_size) {
> +                av_aes_crypt(a, bd->uks.keys[i].u8, &buf[key_pos], 1, NULL, 1); // decrypt unit key
> +                /* 
> +                printf("Key Enc %i is ", i); 
> +                for (j = 0; j < 16; j++) printf("%02x", buf[key_pos + j]);
> +                printf("\n");
> +                printf("Key Dec %i is ", i); 
> +                for (j = 0; j < 16; j++) printf("%02x", bd->uks.keys[i].key[j]);
> +                printf("\n");
> +                */
> +            }

There should be no such debug printfs in the final version.

> --- Makefile	(revision 31616)
> +++ Makefile	(working copy)
> @@ -513,6 +513,7 @@
>                stream/stream.c \
>                stream/stream_cue.c \
> +              stream/stream_bd.c \
>                stream/stream_file.c \

alphabetical order

Diego