[MPlayer-dev-eng] simple Blu-ray playback [Patch]

[Alexander Roalter]

On 02.07.2010 08:14, Reimar Döffinger wrote:
> On Fri, Jul 02, 2010 at 01:07:24AM +0200, Alexander Roalter wrote:
>> I borrowed the configure changes from Benjamin Zores' patch for libbluray.
> 
> I don't see a point in being able to disable this, so the configure
> part should be unnecessary.
> 
>> +//static const char *BD_MKB_PATH = "/%s/AACS/MKB_RO.inf";
> 
> Hm?
> 
>> +struct uk {
>> +    uint8_t key[16];
>> +};
> 
> This and everything else must be sufficiently aligned for
> 64-bit access.
> Maybe you could try "stealing" the "union aes_block" approach
> from the new libavutil/aes.c?
This is actually quite an elegant solution.

>> +    uint8_t vuk[16];
>> +    uint8_t iv[16];
> 
> (note it does not really matter for the malloced ones like
> above, but it does matter here).
inserted a dummy alignment variable, it won't win a prize for beauty,
but it should work.

> Not reviewed the rest...

Made changes other changes according to the notes from Diego;
Thrown out the configure part, since there are no dependencies worth
checking.



-- 
cheers,
Alex
-------------- next part --------------
A non-text attachment was scrubbed...
Name: bd_stream_6.diff
Type: text/x-patch
Size: 11573 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20100702/691285d6/attachment.bin>