[MPlayer-dev-eng] [rfc][patch] mplayer-mt, -lavdopts threads=2 and -vo gl failure on mpeg-1 and theora

[Reimar Döffinger]

On Tue, Jan 19, 2010 at 03:09:58PM +0200, Uoti Urpala wrote:
> On Tue, 2010-01-19 at 08:00 +0100, Reimar Döffinger wrote:
> > On Tue, Jan 19, 2010 at 07:28:48AM +0300, Yuriy Kaminskiy wrote:
> > > And then nothing is displayed. I've looked at code, and, I think, found where
> > > problem lies: threaded decoder calls get_buffer callback from another thread
> > > (this is actually documented in ffmpeg-mt/doc/multithreading.txt: with mt-aware
> > > decoders, draw_horiz_band, get_buffer and release_buffer callbacks can be called
> > > from different threads), but GL context is per-thread, and all GL function fails.
> > 
> > get_buffer is not called unless you use -dr. Either your analysis is wrong or just
> > don't use -dr (on about 99% of systems it is not measurably faster anyway, and I
> > think it is still marked as experimental).
> 
> -dr only affects the VO part. The option has no effect on how frames are
> handled earlier in the filter chain.

I don't think the GL context particularly cares about the filter chain.
But yes, I meant (libvo) get_image when I said get_buffer.